Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (2)
@b-zee b-zee Jun 13, 2023
Perhaps a rename to `REQUEST_TIMEOUT_DEFAULT` to highlight this is a fallback value? I do prefer defaults to be more higher up though, so it could also be an idea to not make `new_client` accept an `Option` and specify this default somewhere in `main`.
Outdated
sn_networking/src/lib.rs
joshuef b-zee
@b-zee b-zee Jun 13, 2023
I personally prefer keeping the parsing with clap. Like this: ```suggestion #[clap(long = "timeout", global = true, value_parser = |t: &str| -> Result<Duration> { Ok(t.parse().map(Duration::from_secs)?) })] ``` But then a `fn` instead of inlined.
Outdated
sn_cli/src/cli.rs
joshuef