feat: faucet server and cli DBC read #486
Conversation
| /// Run the faucet server. | ||
| /// | ||
| /// This will listen on port 8000 and send tokens to any request. | ||
| /// | ||
| /// # Example | ||
| /// | ||
| /// ```bash | ||
| /// # run faucet server | ||
| /// cargo run --features="local-discovery" --bin faucet --release -- server | ||
| /// | ||
| /// # query faucet server for DBC at `get local wallet address` | ||
| /// curl "localhost:8000/`cargo run --features="local-discovery" --bin safe --release wallet address | tail -n 1`" > dbc_hex | ||
| /// | ||
| /// # feed DBC to local wallet | ||
| /// cat dbc_hex | cargo run --features="local-discovery" --bin safe --release wallet read | ||
| /// | ||
| /// # balance should be updated | ||
| /// ``` |
There was a problem hiding this comment.
Docs are here for now, might be useful to have them where we need them
There was a problem hiding this comment.
will this work w/o local-discovery?
There was a problem hiding this comment.
I tried with local-discovery and got this error
willie@gagarin:~/projects/maidsafe/safe_network$ cargo run --features="local-discovery" --bin faucet --release -- server
Finished release [optimized] target(s) in 0.25s
Running `target/release/faucet server`
🔗 Connected to the Network thread 'main' panicked at 'Faucet wallet shall be created successfully.: Bincode(Custom("deserialized bytes don't encode a group element"))', /home/willie/projects/maidsafe/safe_network/sn_transfers/src/dbc_genesis.rs:108:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
And a similar result without local-discovery
willie@gagarin:~/projects/maidsafe/safe_network$ cargo run --bin faucet --release -- server
Finished release [optimized] target(s) in 0.24s
Running `target/release/faucet server`
⠐ Connecting to The SAFE Network... The client still does not know enough network nodes.
🔗 Connected to the Network thread 'main' panicked at 'Faucet wallet shall be created successfully.: Bincode(Custom("deserialized bytes don't encode a group element"))', /home/willie/projects/maidsafe/safe_network/sn_transfers/src/dbc_genesis.rs:108:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
sn_cli/src/subcommands/wallet.rs
Outdated
| @@ -39,6 +40,8 @@ pub enum WalletCmds { | |||
| /// variable to a path you would prefer to work with. | |||
| #[clap(verbatim_doc_comment)] | |||
| Deposit, | |||
| /// Read a DBC from stdin and deposit it to the local wallet. | |||
| Read, | |||
There was a problem hiding this comment.
Hey Anselme,
I'm not sure about adding this as another command in addition to deposit. The same functionality could be added to the deposit command.
Unless there is something distinctly different about this that I'm missing?
There was a problem hiding this comment.
I do like being able to read from stdin btw. We had that in the old CLI. However, I don't think it merits having another separate command.
There was a problem hiding this comment.
I agree, it should be Deposit. If I understand correctly, deposit reads files in a path provided as arg. Would it make sense to read from stdin if the path argument is not provided?
There was a problem hiding this comment.
Since the path wasn't an argument this is what I did:
# read from default path (unchanged)
safe wallet deposit
# read from stdin (new feature)
safe wallet deposit --stdin
And removed the Read
Good one @jacderida!
reviewpad
bot
added
large
Description
Summary generated by Reviewpad on 06 Jul 23 02:59 UTC
This pull request adds a new feature to the codebase. It includes changes to the
Cargo.lock,sn_cli/src/subcommands/wallet.rs,sn_node/Cargo.toml,sn_node/src/bin/faucet/faucet_server.rs, andsn_node/src/bin/faucet/main.rsfiles.The changes in the
Cargo.lockfile include the addition of theasciiandchunked_transferpackages.The
sn_cli/src/subcommands/wallet.rsfile now includes a new command,Read, which reads a DBC from stdin and deposits it to the local wallet.In the
sn_node/Cargo.tomlfile, thepathfor thefaucetbinary has been changed fromsrc/bin/faucet.rstosrc/bin/faucet/main.rs.A new file,
sn_node/src/bin/faucet/faucet_server.rs, has been added. This file contains the implementation of the faucet server, which listens on port 8000 and sends tokens to any request.The
sn_node/src/bin/faucet.rsfile has been renamed tosn_node/src/bin/faucet/main.rs.