Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic mock routing functions #852

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@nbaksalyar
Copy link
Member

commented Sep 18, 2019

Closes #838, closes #839, closes #840.

@nbaksalyar nbaksalyar requested review from jeanphilippeD and lionel1704 Sep 18, 2019
@nbaksalyar nbaksalyar requested a review from ustulation as a code owner Sep 18, 2019
@nbaksalyar nbaksalyar added this to In progress in Vaults Phase 2 via automation Sep 18, 2019
@nbaksalyar nbaksalyar moved this from In progress to Review in progress in Vaults Phase 2 Sep 18, 2019
Vaults Phase 2 automation moved this from Review in progress to Reviewer approved Sep 18, 2019
Copy link
Contributor

left a comment

Looks good to me.

match event {
RoutingEvent::Consensus(custom_event) => {
match bincode::deserialize::<ParsecAction>(&custom_event) {
Ok(parsec_action) => client_handler.handle_parsec_action(parsec_action),

This comment has been minimized.

Copy link
@jeanphilippeD

jeanphilippeD Sep 18, 2019

Contributor

Maybe worth being a bit more precised : handle_consensused_parsec_action?

This comment has been minimized.

Copy link
@nbaksalyar

nbaksalyar Sep 18, 2019

Author Member

Maybe even handle_consensused_action? And rename ParsecAction to ConsensusAction?

This comment has been minimized.

Copy link
@jeanphilippeD

jeanphilippeD Sep 18, 2019

Contributor

Seem good, there does not seem to be a need to mention Parsec in the vault code.
then best to make sure we do not use that word in other functions as well.

It allows to vote for PARSEC events and also get consensused events in the Vault event loop.
@nbaksalyar nbaksalyar force-pushed the nbaksalyar:mock-routing branch from 6cbed85 to a066a3d Sep 18, 2019
Vaults Phase 2 automation moved this from Reviewer approved to Review in progress Sep 18, 2019
Vaults Phase 2 automation moved this from Review in progress to Reviewer approved Sep 18, 2019
Copy link
Contributor

left a comment

Looks good (will have to see if the poll non interleaved loops work out but good for now).

@nbaksalyar nbaksalyar merged commit 8943788 into maidsafe:master Sep 18, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Vaults Phase 2 automation moved this from Reviewer approved to Done Sep 18, 2019
@nbaksalyar nbaksalyar deleted the nbaksalyar:mock-routing branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.