Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look up by message id #891

Merged
merged 2 commits into from Nov 6, 2019

Conversation

@ustulation
Copy link
Member

ustulation commented Nov 6, 2019

Don't look up by client id as the same client logging in from multiple connections will have the same id so impossible to disambiguate when responding.

Don't look up by client id as the same client logging in from multiple connections will have the same id so impossible to disambiguate when responding.
Copy link
Member

nbaksalyar left a comment

Looks great 👍

Also, don't check for similar ID being already challenged, as we want to accept similar IDs from different addresses and consequently want to accept challenges from multiple connections of the same ID
@ustulation ustulation force-pushed the ustulation:lookup-by-msg-id branch from 11a4768 to f91d019 Nov 6, 2019
@ustulation ustulation merged commit 876d08a into maidsafe:vNext Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@ustulation ustulation deleted the ustulation:lookup-by-msg-id branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.