fix/naming: fix up some names for consistency #80
Conversation
src/mutable_data.rs
Outdated
| @@ -714,7 +714,7 @@ impl Data { | |||
| } | |||
| } | |||
|
|
|||
| pub fn owner(&self) -> PublicKey { | |||
| pub fn owners(&self) -> PublicKey { | |||
There was a problem hiding this comment.
This should stay as owner because generally we shouldn't care if it's a multisig/BLS key or some other key.
It'd be better to change the .owners field name in SeqMutableData and UnseqMutableData.
src/mutable_data.rs
Outdated
| /// Contains a set of owners of this data. DataManagers enforce that a mutation request is | ||
| /// coming from the MaidManager Authority of the Owner. | ||
| owners: PublicKey, | ||
| /// Contains the owner of this data. DataManagers enforce that a mutation request is coming from |
There was a problem hiding this comment.
Just noticed that this comment mentions legacy names from Vaults.
Could you please change it to something like
/// Contains the public key of an owner or owners of this data.
/// Data Handlers in vaults enforce that a mutation request has a valid signature of the owner.?
src/mutable_data.rs
Outdated
| /// Contains a set of owners of this data. DataManagers enforce that a mutation request is | ||
| /// coming from the MaidManager Authority of the Owner. | ||
| owners: PublicKey, | ||
| /// Contains the owner of this data. DataManagers enforce that a mutation request is coming from |
|
Before we merge this, @m-cat could you please raise a PR for SAFE Client Libs to make it compatible with these changes? There are some places in Mock Vault where we use the |
|
Sure, I am just waiting for the tiny-keccak compatibility fixes as I can't compile and test SCL right now, it seems. |
No description provided.