This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
refactor/response: add Request::error_response and simplify Response variants #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madadam
reviewed
Jul 31, 2019
| ListAuthKeysAndVersion => Response::ListAuthKeysAndVersion(Err(error)), | ||
| InsAuthKey { .. } => Response::Mutation(Err(error)), | ||
| DelAuthKey { .. } => Response::Mutation(Err(error)), | ||
| } |
There was a problem hiding this comment.
You can reduce the amount of code here a bit by grouping all the requests that map to Response::Mutation:
Request::PutIData(_)
| Request::DeleteUnpubIData(_)
...
| Request::DelAuthKey { .. } => Response::Mutation(Err(error)),
mrcnski
force-pushed
the
error-response
branch
2 times, most recently
from
8ea72f7
to
39fe1fb
Compare
madadam
previously approved these changes
Jul 31, 2019
From the Rust docs: > Only implement Into if a conversion to a type outside the current crate is required. From cannot do these type of conversions because of Rust's orphaning rules.
lionel-faber
approved these changes
Jul 31, 2019
nbaksalyar
approved these changes
Aug 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.