Warn when connection to Spamhaus times out #1817
Conversation
| @@ -293,6 +293,8 @@ def run_network_checks(env, output): | |||
| zen = query_dns(rev_ip4+'.zen.spamhaus.org', 'A', nxdomain=None) | |||
| if zen is None: | |||
| output.print_ok("IP address is not blacklisted by zen.spamhaus.org.") | |||
| elif zen == "[timeout]": | |||
| output.print_warning("Connection to zen.spamhaus.org timed out. We could not determine whether your server's IP address is blacklisted. Please try again later.") | |||
There was a problem hiding this comment.
Maybe we could add a the website endpoint that we point the users to when the IP/domain turns out to be legitimately blocked (http://www.spamhaus.org/query/ip/<ipv4>), for example:
Connection to zen.spamhaus.org timed out. We could not determine whether your server's IP address is blacklisted. Please try again later, or see http://www.spamhaus.org/query/ip/1.1.1.1
| @@ -678,6 +680,8 @@ def check_mail_domain(domain, env, output): | |||
| dbl = query_dns(domain+'.dbl.spamhaus.org', "A", nxdomain=None) | |||
| if dbl is None: | |||
| output.print_ok("Domain is not blacklisted by dbl.spamhaus.org.") | |||
| elif dbl == "[timeout]": | |||
| output.print_warning("Connection to dbl.spamhaus.org timed out. We could not determine whether the domain {} is blacklisted. Please try again later.".format(domain)) | |||
There was a problem hiding this comment.
Same here: http://www.spamhaus.org/query/domain/example.com:
Connection to dbl.spamhaus.org timed out. We could not determine whether the domain example.com is blacklisted. Please try again later, or see http://www.spamhaus.org/query/domain/example.com
|
This issue has never happened for me and I assume it is intermittent, so we don't need to make the error message more informative. Merging! |
|
I think it may depend on who your providers are - for Hetzner, for whatever reason all Spamhaus queries take either very long (in the ballpark of the 30 seconds) or just time out. |
This prints a warning rather than an error when a
Timeoutis raised andquery_dns()then returns"[timeout]".Decided against explicit checks for Spamhaus error codes (zen dbl) for now to keep it simple.
closes #1816