Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding a manual CAA record #1155

Merged
merged 2 commits into from Apr 30, 2017
Merged

Conversation

yodax
Copy link
Contributor

@yodax yodax commented Apr 12, 2017

For #1154 and discourse topic

This PR allows a user to add a CAA record manually.

schermafbeelding 2017-04-12 om 14 38 29

This results in:

dig @ns1.box.test.domain test.domain CAA

; <<>> DiG 9.11.0-P3 <<>> @ns1.box.test.domain test.domain CAA
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 18331
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 2, ADDITIONAL: 5
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;test.domain.			IN	CAA

;; ANSWER SECTION:
test.domain.		1800	IN	CAA	0 issuewild "letsencrypt.org"

;; AUTHORITY SECTION:
test.domain.		1800	IN	NS	ns1.box.test.domain.
test.domain.		1800	IN	NS	ns2.box.test.domain.

;; ADDITIONAL SECTION:
ns1.box.test.domain.	1800	IN	A	xx
ns2.box.test.domain.	1800	IN	A	xx
ns1.box.test.domain.	1800	IN	AAAA	xx
ns2.box.test.domain.	1800	IN	AAAA	xx

;; Query time: 24 msec
;; SERVER: xx#53(xx)
;; WHEN: Wed Apr 12 14:24:28 CEST 2017
;; MSG SIZE  rcvd: 206

Maybe in the future we could make this automatic when we request certificates from lets encrypt.

@@ -125,7 +126,7 @@
<tr><td>email</td> <td>The email address of any administrative user here.</td></tr>
<tr><td>password</td> <td>That user&rsquo;s password.</td></tr>
<tr><td>qname</td> <td>The fully qualified domain name for the record you are trying to set. It must be one of the domain names or a subdomain of one of the domain names hosted on this box. (Add mail users or aliases to add new domains.)</td></tr>
<tr><td>rtype</td> <td>The resource type. Defaults to <code>A</code> if omitted. Possible values: <code>A</code> (an IPv4 address), <code>AAAA</code> (an IPv6 address), <code>TXT</code> (a text string), <code>CNAME</code> (an alias, which is a fully qualified domain name &mdash; don&rsquo;t forget the final period), <code>MX</code>, <code>SRV</code>, or <code>SSHFP</code>.</td></tr>
<tr><td>rtype</td> <td>The resource type. Defaults to <code>A</code> if omitted. Possible values: <code>A</code> (an IPv4 address), <code>AAAA</code> (an IPv6 address), <code>TXT</code> (a text string), <code>CNAME</code> (an alias, which is a fully qualified domain name &mdash; don&rsquo;t forget the final period), <code>MX</code>, <code>SRV</code>, or <code>SSHFP</code>, or <code>CAA</code>.</td></tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra "or".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@JoshData JoshData merged commit d2b7204 into mail-in-a-box:master Apr 30, 2017
@kimusan
Copy link
Contributor

kimusan commented Jan 16, 2018

Would it be possible to get them automatically added to the ones automatically created by miab (the letsencrypt ones)?

@yodax
Copy link
Contributor Author

yodax commented Jan 16, 2018

@kimusan Thanks for the reply, would you mind creating a separate issue for it? That allows for better tracking 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants