Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme for Mail-in-a-Box #1529

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@just4d
Copy link

just4d commented Mar 5, 2019

Dark theme for MiaB is, at my side, a need because my eyes are, every day more, suffering with white / light backgrounds then, here you have my proposal ...

DARK THEME - SCREENSHOT... http://bit.ly/2SIiioL

CUSTOMIZATIONS ...

  • Customized the template files: index.html and check-status.html and created/ added custom.bootstrap.(min).css files to override 'bootstrap' defaults for current 'light' theme.

  • Patched the file: setup/management.sh to move my new custom files CSS (custom.dark.boostrap.css, custom.dark.boostrap.min.css) and IMAGES (white logo(s), white icon(s) ). This change must be considered TEMPORAL because surely @JoshData will finally wish to integrate provided files into his repository.

HOW TO TEST IT ...

git clone -b master https://github.com/just4d/custom-dark.git && git clone -b dark_190304 https://github.com/just4d/mailinabox.git

NOTES ...

- Do never use it on 'production' servers. Everything here is being provided to make easy to the MiaB main developer to take the decision to merge or not this Pull Request into the mail-in-a-box ''master' and to consider the convenience to make it the default 'theme'.

  • Development server used for this job has been deleted and the development domain shown in the screenshot has been parked.

@JoshData Waiting your feedback :)

just4d added some commits Mar 4, 2019

@jrsupplee

This comment has been minimized.

Copy link

jrsupplee commented Mar 6, 2019

custom-dark.bootstrap(.min).css files do not seem to be in the patch.

Why not implement this so that the user can choose between light and dark themes?

@just4t

This comment has been minimized.

Copy link

just4t commented Mar 6, 2019

Location: https://github.com/just4d/custom-dark . Tested again and worked whell at my side... !? Result:

root@web:~# git clone -b master https://github.com/just4d/custom-dark.git
Cloning into 'custom-dark'...
remote: Enumerating objects: 50, done.
remote: Counting objects: 100% (50/50), done.
remote: Compressing objects: 100% (49/49), done.
remote: Total 50 (delta 13), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (50/50), done.
root@web:~# ls
custom-dark  mailinabox
root@web:~# cd custom-dark
root@web:~/custom-dark# ls
css  images
root@web:~/custom-dark# cd css
root@web:~/custom-dark/css# ls
custom.dark.bootstrap.css  custom.dark.bootstrap.min.css
root@web:~/custom-dark/css#
  1. Try to run git clone -b master https://github.com/just4d/custom-dark.git once
  • Check the files have been cloned at /root/custom-dark/css/ folder ...
    and then (again, the first one):
    git clone -b master https://github.com/just4d/custom-dark.git && git clone -b dark_190304 https://github.com/just4d/mailinabox.git

-> Please, confirm works or not, yet at your end.

  1. That shoud be the right way to go but coding it would be hard (even maintenace, afterwards) then, I don't think @JoshData would be open for that... Better to wait his answer/ opinion about that first.

just4d added some commits Mar 7, 2019

Merged custom CSS & PNG files management for 'dark'
From now to install it, works with:  git clone -b dark_190304 https://github.com/just4d/mailinabox.git , only.
@just4d

This comment has been minimized.

Copy link
Author

just4d commented Mar 7, 2019

Improved installation by merging in the custom 'dark theme' CSS & PNG files management into /setup/management.sh file. Now to install it, works with: git clone -b dark_190304 https://github.com/just4d/mailinabox.git , only.

@just4d

This comment has been minimized.

Copy link
Author

just4d commented Mar 9, 2019

This pull request is going to be closed now in favor of this new Custom-Dark theme built as a standalone add-on for Mail-in-a-Box.

@jrsupplee As your requested, the new version, as standalone add-on, will allow you to apply the custom-dark theme and restore the default-light one at anytime...

  • Please, test it ad your end and post here is any issue arise at your end.

In all cases, your comments about, are very important to make this new Mail-in-a-Box add-on to leave the current BETA level.

Waiting your feedback,

@just4d just4d closed this Mar 9, 2019

@just4d just4d deleted the just4d:dark_190304 branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.