Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interm upgrade step from Nextcloud 13 -> 14 #1605

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@jvolkenant
Copy link
Contributor

commented Jul 9, 2019

PR to fix #1598 adds interm upgrade to Nextcloud 14 if detected version is Nextcloud 13 and limits user_external to install github version for Nextcloud 15 only (user_external is no longer included as a base package starting with Nextcloud 15).

Something to note for the current way that setup/nextcloud.sh is setup. InstallNextcloud function will install contacts and calendar versions for the latest version of Nextcloud even if they are not the recommended versions for the interm editions. This is fine since we don't activate the plugins until later in nextcloud.sh, and by that point we would have the latest version laid down.

I did a fresh install of 18.04, installed with v0.40, then switched to master with these changes and had upgraded through 14 to get to 15.

@JoshData JoshData merged commit bea5eb0 into mail-in-a-box:master Jul 12, 2019

@JoshData

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thanks!

@JoshData

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Before I re-release v0.42, can anyone else confirm that a v0.40 => master branch direct upgrade works fine with Nextcloud?

@just4t

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Before I re-release v0.42 ...

  • Please, consider to use a different version number for your mentioned re-release ... Something like v0.42b or v0.43 should be fine/ enough to warn users that already tried or already upgraded to v0.42 earlier, about they need/ must to apply an upgrade again.
@JoshData

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Yes, of course. :) I'll make it v0.42b.

@sfPlayer1

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

I think there's still a conceptual problem around backup restores.

The gradual Nextcloud migration serves to migrate the user data, but it's being controlled through the currently installed Nextcloud version - not the data's Nextcloud version. This is obviously mismatched when restoring an older backup according to the documentation, a high visibility example is a restore from v0.30 to v0.42.

@JoshData

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Good observation!

@jvolkenant jvolkenant deleted the jvolkenant:nextcloud_fix1598 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.