Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dns zone transfer from IPv6 #1643

Merged
merged 2 commits into from Oct 28, 2019
Merged

Allow dns zone transfer from IPv6 #1643

merged 2 commits into from Oct 28, 2019

Conversation

@notEvil
Copy link
Contributor

notEvil commented Sep 14, 2019

A small step towards IPv6

@JoshData

This comment has been minimized.

Copy link
Member

JoshData commented Oct 5, 2019

A domain can resolve to both an IPv4 and an IPv6 address, and in that case we would end up returning both. Will that work? If so, domains can also resolve to multiple IPv4 and/or multiple IPv6 addresses, and maybe we should return the whole set rather then the first of each.

@notEvil

This comment has been minimized.

Copy link
Contributor Author

notEvil commented Oct 8, 2019

I don't know if I follow. Do you suggest to change values.append(str(ipv6_response[0])) into values.extend(map(str, ipv6_response)) and similar for ipv4? The change here already does what you are describing (returns both).

@JoshData

This comment has been minimized.

Copy link
Member

JoshData commented Oct 8, 2019

Right. If ipv6_response or ipv4_response each contain more than one value, we might as well return all of them, rather than just the first IPv6 address and the first IPv4 address.

@JoshData

This comment has been minimized.

Copy link
Member

JoshData commented Oct 11, 2019

Thanks, that makes the code a bit cleaner.

@JoshData JoshData merged commit 7558ffd into mail-in-a-box:master Oct 28, 2019
victorlap added a commit to victorlap/mailinabox that referenced this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.