New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mabola skin and ThreeCol layout plugin #960

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@v60fan

v60fan commented Oct 1, 2016

Mabola skin: there are no releases or tags in the mabola repo, so have cloned the master
Threecol plugin: the v0.4 release doesn't properly allow Preview Pane location to be set, but the master does

A bit strange to me that adding $rcmail_config['plugins'] is required, but this is what allows it to work

Add mabola skin and ThreeCol layout plugin
Mabola skin: there are no releases or tags in the mabola repo, so have cloned the master
Threecol plugin: the v0.4 release doesn't properly allow Preview Pane location to be set, but the master does

A bit strange to me that adding $rcmail_config['plugins'] is required, but this is what allows it to work
@kimusan

This comment has been minimized.

Show comment
Hide comment
@kimusan

kimusan Oct 3, 2016

I just added it to the normal array of plugins in $config and that worked for me.

kimusan commented Oct 3, 2016

I just added it to the normal array of plugins in $config and that worked for me.

@n3storm

This comment has been minimized.

Show comment
Hide comment
@n3storm

n3storm Jan 12, 2017

Hi, Mabola developer here. First, thanks for adding Mabola to your distribution.
We have updated README with installation instructions and also referenced Mabola Blue variation (inherits from Mabola, so both should be installed)

Do not hesitate to create issues for us if you find any bugs.

n3storm commented Jan 12, 2017

Hi, Mabola developer here. First, thanks for adding Mabola to your distribution.
We have updated README with installation instructions and also referenced Mabola Blue variation (inherits from Mabola, so both should be installed)

Do not hesitate to create issues for us if you find any bugs.

@n3storm

This comment has been minimized.

Show comment
Hide comment
@n3storm

n3storm Jan 12, 2017

Cloning master is ok, we will never bring up to master non tested fixes.

n3storm commented Jan 12, 2017

Cloning master is ok, we will never bring up to master non tested fixes.

@cromulus

This comment has been minimized.

Show comment
Hide comment
@cromulus

cromulus Jan 16, 2017

Contributor

My hunch is that it is better to pull against a specific commit, as opposed to HEAD simply for reproducibility, especially if master is comprised of essentially releases, as indicated by @n3storm.

Contributor

cromulus commented Jan 16, 2017

My hunch is that it is better to pull against a specific commit, as opposed to HEAD simply for reproducibility, especially if master is comprised of essentially releases, as indicated by @n3storm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment