Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLSA to the list of allowed custom records #975

Closed
wants to merge 1 commit into from

Conversation

rxcomm
Copy link
Contributor

@rxcomm rxcomm commented Oct 13, 2016

This commit allows custom TLSA records to be added to the
managed domains. Since the criteria for the primary domain TLSA
record is 3 1 1 and the default key for all certificates is the
same one, the same TLSA record generated for the primary domain
will work for all managed domains.

Note that this commit does not modify the custom DNS configuration
page. It only permits TLSA records to be added. Currently the only
way to do that is by manually editing the custom.yaml file in
/home/user-data/dns.

This commit allows custom TLSA records to be added to the
managed domains. Since the criteria for the primary domain TLSA
record is 3 1 1 and the default key for all certificates is the
same one, the same TLSA record generated for the primary domain
will work for all managed domains.

Note that this commit does not modify the custom DNS configuration
page. It only permits TLSA records to be added. Currently the only
way to do that is by manually editing the custom.yaml file in
/home/user-data/dns.
@JoshData
Copy link
Member

I'd rather combine this with some validation to make it difficult for setting a custom record to break nsd completely.

@rxcomm
Copy link
Contributor Author

rxcomm commented Oct 15, 2016

Doing this with custom dns records is probably a bad idea on my part. Perhaps the best thing is to move the call to build_tlsa_record() for _443._tcp out of the primary hostname section of dns_update.py. If you agree, go ahead and close this one and I'll see if I can come up with something along those lines.

MiaB is fantastic, BTW!

@JoshData
Copy link
Member

Thanks.

Closing issues and deleting code are two of my favorite things, so happy to close.

@JoshData JoshData closed this Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants