[MMC-1891] Updates to build and readme for jitpack #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@paul-turner @sean-farrell Only one review required but I tagged both of y'all so you would know that it's here |
paul-turner
approved these changes
Jan 13, 2020
paul-turner
left a comment
paul-turner
left a comment
There was a problem hiding this comment.
Was able to build referencing the snapshot version on jitpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make our repo compliant with Jitpack I turned the api module from a java module to an android module. I also updated the README with instructions for adding the SDK to your project.
Testing
Note
I haven't created the 0.1.0 tag yet so when adding the dependency replace that with 'master-SNAPSHOT' for testing