Add "Mark as Read" feature #461

Closed
bnvk opened this Issue Feb 26, 2014 · 4 comments

Projects

None yet

3 participants

Owner
bnvk commented Feb 26, 2014

No description provided.

@bnvk bnvk added this to the Beta milestone Feb 26, 2014
@bnvk bnvk self-assigned this Feb 26, 2014
Contributor
smari commented Feb 27, 2014

+1

Contributor
smari commented Mar 20, 2014

Closed by @lieblingswelt in 55905ed

@smari smari closed this Mar 20, 2014
Owner
bnvk commented Mar 20, 2014

Thanks so much @lieblingswelt the backend actions work great. I need to re-open this as one thing it does not do is provide any UI feedback that something has happened. Ideally, either removing (when marking read) the in_new class from the <tr> or adding the class.

I'm totally up for doing this but if you want to try, it should be pretty easy to add something like:

$.each(mailpile.messages_cache, function(key, mid) {
  $('#pile-message-' + mid).removeClass('in_new');
});
@bnvk bnvk reopened this Mar 20, 2014
Contributor

Hey! Thanks reviewing so quickly! I wouldn't get to it before Wednesday. So feel free to go ahead and finish or leave it open and I can turn to it then.
I would like to take a look at tests when GUI tests are ready to use.

@bnvk bnvk closed this Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment