Fix setup dialog offering revoked key (#2142) #2145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds screening of the existing keys that are considered to be listed in the Add Account-Create a new Account-Security and Privacy-Encryption pull down list, so that disabled, revoked and expired keys are excluded, fixing #2142.
Note: The crypto/gpg/keylist/secret command SYNOPSIS formerly listed an argument "address" but that argument was not actually implemented. This may be because it is easier to implement the screening of the key User IDs for the correct email address in account-form.html than to pass the email address from the html interface back to the crypto/gpg/keylist/secret command.
This has been tested on the current Mailpile master, on Debian stretch, using gpg 2.1.18, with a set of test keys including disabled, revoked and expired keys.