Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native PGP keyserver lookups (Issue 2159). #2193

Conversation

@philratcliffe
Copy link
Contributor

commented Dec 14, 2018

Updates so that Mailpile performs PGP key server lookups directly rather than through GnuPG.

Add native PGP keyserver lookups (Issue 2159).
Modified code so Mailpile performs PGP key server lookups directly
rather than through GnuPG.
@BjarniRunar

This comment has been minimized.

Copy link
Member

commented Dec 22, 2018

Thanks for this, and apologies for the lack of reactions. I've been going through a bit of burnout lately, so I've been spending time on other things. I'll take a look as soon as I can.

@philratcliffe

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2018

No worries @BjarniRunar; thanks for creating such a great email client!

@fiza1160

This comment has been minimized.

Copy link

commented Feb 2, 2019

KEY_SERVER_BASE_URLS = [
"https://sks-keyservers.net/pks/lookup",
"https://hkps.pool.sks-keyservers.net/pks/lookup",
]

This comment has been minimized.

Copy link
@wiktor-k

wiktor-k Apr 15, 2019

Contributor

In my experience https://keyserver.ubuntu.com/ has the highest uptime and lowest response times.

@BjarniRunar

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Just a note: Merging this has become higher priority for me, since it will allow Mailpile to put upper limits on key size and thus protect GnuPG from SKS keyserver spam, as described in https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f

For now we've reconfigured Mailpile in master/nightly to avoid the SKS keyservers entirely, but I think it would still be valuable to our users to be able to fall back to the keyserver pool as a last resort, simply because all the modern replacements are still at an early stage of development/deployment.

I'm going to try and find time to look at this, this week. Sorry again about the long delay.

@BjarniRunar BjarniRunar merged commit 469b807 into mailpile:master Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.