Firefox instructions incomplete #50

Closed
unhammer opened this Issue Jun 11, 2013 · 18 comments

Comments

Projects
None yet
7 participants
@unhammer
Contributor

unhammer commented Jun 11, 2013

What do you do after following "Build instructions" in order to actually install the Firefox addon? I also see the makefile trying to call "cfx" which I do not have installed, do I need to install the Addon SDK? The readme should probably say so in that case.

@matze

This comment has been minimized.

Show comment
Hide comment
@matze

matze Jun 12, 2013

Yes, you have to install the Addon SDK to get the cfx tool. However, I am still not able to run it:

$ make start-ff 
Start Firefox...
ModuleNotFoundError: unable to satisfy: require(common/lib/defaults) from
  /home/matthias/dev/mailvelope/firefox/data/common/lib/controller.js:22:
Looked for it in:
  /home/matthias/dev/mailvelope/firefox/common/lib/defaults.js
  /home/matthias/dev/mailvelope/firefox/packages/ppg-api/lib/common/lib/defaults.js
  /home/matthias/dev/addon-sdk-1.14/lib/common/lib/defaults.js

Obviously, the plugin does not search in the root directory for the common directory.

matze commented Jun 12, 2013

Yes, you have to install the Addon SDK to get the cfx tool. However, I am still not able to run it:

$ make start-ff 
Start Firefox...
ModuleNotFoundError: unable to satisfy: require(common/lib/defaults) from
  /home/matthias/dev/mailvelope/firefox/data/common/lib/controller.js:22:
Looked for it in:
  /home/matthias/dev/mailvelope/firefox/common/lib/defaults.js
  /home/matthias/dev/mailvelope/firefox/packages/ppg-api/lib/common/lib/defaults.js
  /home/matthias/dev/addon-sdk-1.14/lib/common/lib/defaults.js

Obviously, the plugin does not search in the root directory for the common directory.

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Jun 12, 2013

Member

The version on master is quite old. Please use this branch: https://github.com/toberndo/mailvelope/tree/firefox

Member

toberndo commented Jun 12, 2013

The version on master is quite old. Please use this branch: https://github.com/toberndo/mailvelope/tree/firefox

@matze

This comment has been minimized.

Show comment
Hide comment
@matze

matze Jun 12, 2013

Is there anything else required? I can start a new Firefox instance with the addon enabled but there is no further UI besides a button that launches the external editor. After pasting the text back into the provider's input box, the button will never work again.

matze commented Jun 12, 2013

Is there anything else required? I can start a new Firefox instance with the addon enabled but there is no further UI besides a button that launches the external editor. After pasting the text back into the provider's input box, the button will never work again.

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Jun 13, 2013

Member

In the addon toolbar you should also see an icon to lauch the options page which is functional. The rest is work in progress.

Member

toberndo commented Jun 13, 2013

In the addon toolbar you should also see an icon to lauch the options page which is functional. The rest is work in progress.

@astrolitterbox

This comment has been minimized.

Show comment
Hide comment
@astrolitterbox

astrolitterbox Jun 20, 2013

It works nicely with Gmail, but when I try to add a Roundcube site, nothing happens -- the new Mailvelope options tab doesn't open. Is this not yet implemented for Firefox 21?
A really nice tool, anyway!

It works nicely with Gmail, but when I try to add a Roundcube site, nothing happens -- the new Mailvelope options tab doesn't open. Is this not yet implemented for Firefox 21?
A really nice tool, anyway!

@CalRobert

This comment has been minimized.

Show comment
Hide comment
@CalRobert

CalRobert Jun 27, 2013

In case anyone else here is wondering like I was, you need to make copy-common and then make dist-ff. Thanks to the author for his tweet!

In case anyone else here is wondering like I was, you need to make copy-common and then make dist-ff. Thanks to the author for his tweet!

@tfl

This comment has been minimized.

Show comment
Hide comment
@tfl

tfl Jul 4, 2013

Can't make dist-ff or make start-ff

cuddlefish.packaging.MalformedPackageError: package.json not found in "/home/bla/source/mailvelope/firefox/packages/ppg-api/packages/vold-utils-jplib"

tfl commented Jul 4, 2013

Can't make dist-ff or make start-ff

cuddlefish.packaging.MalformedPackageError: package.json not found in "/home/bla/source/mailvelope/firefox/packages/ppg-api/packages/vold-utils-jplib"

@CalRobert

This comment has been minimized.

Show comment
Hide comment
@CalRobert

CalRobert Jul 4, 2013

did you make copy-common?

did you make copy-common?

@tfl

This comment has been minimized.

Show comment
Hide comment
@tfl

tfl Jul 4, 2013

yep, did it. error persists.

tfl commented Jul 4, 2013

yep, did it. error persists.

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Jul 4, 2013

Member

The version on master is quite old. Please use this branch: https://github.com/toberndo/mailvelope/tree/firefox

Member

toberndo commented Jul 4, 2013

The version on master is quite old. Please use this branch: https://github.com/toberndo/mailvelope/tree/firefox

@tfl

This comment has been minimized.

Show comment
Hide comment
@tfl

tfl Jul 5, 2013

git checkout firefox && make copy-common

same procedure as yesterday...

tfl commented Jul 5, 2013

git checkout firefox && make copy-common

same procedure as yesterday...

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Jul 5, 2013

Member

@tfl If you get the same error message then there is definitely something wrong as ppg-api is not any more part of the firefox branch. Are you sure you checked out the remote branch?

I also added now the current XPI file to the repo: https://github.com/toberndo/mailvelope/raw/firefox/dist/mailvelope.xpi
Switch to 'decrypt in popup' in the security settings as inline is not supported.

Member

toberndo commented Jul 5, 2013

@tfl If you get the same error message then there is definitely something wrong as ppg-api is not any more part of the firefox branch. Are you sure you checked out the remote branch?

I also added now the current XPI file to the repo: https://github.com/toberndo/mailvelope/raw/firefox/dist/mailvelope.xpi
Switch to 'decrypt in popup' in the security settings as inline is not supported.

@tfl

This comment has been minimized.

Show comment
Hide comment
@tfl

tfl Jul 5, 2013

Hmmm, what else should I do other then

$ cd source
$ git clone https://github.com/toberndo/mailvelope.git
$ cd mailvelope
$ git checkout firefox
$ make build (or copy-common or start-ff or...)

I'm not a git guru ;)

tfl commented Jul 5, 2013

Hmmm, what else should I do other then

$ cd source
$ git clone https://github.com/toberndo/mailvelope.git
$ cd mailvelope
$ git checkout firefox
$ make build (or copy-common or start-ff or...)

I'm not a git guru ;)

@matze

This comment has been minimized.

Show comment
Hide comment
@matze

matze Jul 5, 2013

You have to checkout the remote branch with

$ git checkout -t origin/firefox

-t sets the remote branch to be upstream for the local one.

matze commented Jul 5, 2013

You have to checkout the remote branch with

$ git checkout -t origin/firefox

-t sets the remote branch to be upstream for the local one.

@tfl

This comment has been minimized.

Show comment
Hide comment
@tfl

tfl Jul 5, 2013

ok, restarted from scratch

$ ... cloned, init and checkout -t
$ git submodule update
....
Checking connectivity... done
fatal: Referenz ist kein Baum: b05c490c35d19c8bd7ada465ca06aa73ee4b1aaf
Konnte 'b05c490c35d19c8bd7ada465ca06aa73ee4b1aaf' in Unterprojekt-Pfad 'dep/firefox/openpgpjs' nicht auschecken.

I think I will try again tomorrow

tfl commented Jul 5, 2013

ok, restarted from scratch

$ ... cloned, init and checkout -t
$ git submodule update
....
Checking connectivity... done
fatal: Referenz ist kein Baum: b05c490c35d19c8bd7ada465ca06aa73ee4b1aaf
Konnte 'b05c490c35d19c8bd7ada465ca06aa73ee4b1aaf' in Unterprojekt-Pfad 'dep/firefox/openpgpjs' nicht auschecken.

I think I will try again tomorrow

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Jul 6, 2013

Member

Oops, seems like I forgot to push a commit. Now it should work:

$ git clone https://github.com/toberndo/mailvelope.git
$ cd mailvelope
$ git checkout -t origin/firefox
$ git submodule init
$ git submodule update
$ make build
Member

toberndo commented Jul 6, 2013

Oops, seems like I forgot to push a commit. Now it should work:

$ git clone https://github.com/toberndo/mailvelope.git
$ cd mailvelope
$ git checkout -t origin/firefox
$ git submodule init
$ git submodule update
$ make build
@Wikinaut

This comment has been minimized.

Show comment
Hide comment
@Wikinaut

Wikinaut Jul 8, 2013

see also #68 Warning "New path should be: require('sdk/simple-storage')" when building for Firefox

Wikinaut commented Jul 8, 2013

see also #68 Warning "New path should be: require('sdk/simple-storage')" when building for Firefox

@toberndo

This comment has been minimized.

Show comment
Hide comment
@toberndo

toberndo Sep 19, 2013

Member

The firefox branch is now merged into master.

Member

toberndo commented Sep 19, 2013

The firefox branch is now merged into master.

@toberndo toberndo closed this Sep 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment