Add WSS support for MQTT over WS #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com>
nmarcetic
changed the title
drasko
requested changes
Apr 7, 2020
charts/mainflux/values.yaml
Outdated
| # hostname: "" | ||
| # tls: | ||
| # hostname: "" | ||
| # secret: "" | ||
|
|
||
| nginx_internal: | ||
| mtls: | ||
| # By default mTLS is disabled. If use mTLS comment this block. |
There was a problem hiding this comment.
Confusing comments, interleaved with two lines of code...
There was a problem hiding this comment.
Ah, sorry, I read too fast. In any case, can you plese rephrade sthi comment to "If mTLS is used" or `"If you use mTLS" to fix the grammar.
blokovi
previously approved these changes
Apr 8, 2020
drasko
requested changes
Apr 8, 2020
charts/mainflux/values.yaml
Outdated
| # hostname: "" | ||
| # tls: | ||
| # hostname: "" | ||
| # secret: "" | ||
|
|
||
| nginx_internal: | ||
| mtls: | ||
| # By default mTLS is disabled. If use mTLS comment this block. |
There was a problem hiding this comment.
Ah, sorry, I read too fast. In any case, can you plese rephrade sthi comment to "If mTLS is used" or `"If you use mTLS" to fix the grammar.
Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com>
Closed
blokovi
pushed a commit
to blokovi/devops
that referenced
this pull request
Apr 9, 2021
* Added WSS support for MQTT over WS Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com> * Resolves remarks Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikola Marcetic n.marcetic86@gmail.com