Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support configuring multiple devices #14
Configuration file format has been modified to support multiple devices.
Note that this PR breaks existing configurations.
Also, support for multiple devices is still somewhat flaky. I think there's some kind of a concurrency issue in the upstream broadlink package due to simultaneous calls to
mcc05 left a comment
All looks good to me, happy with the changes.
On the threading issue on update, why not try a random small delay on each call on top the update interval such as
Such a delay would probably hide the problem, yes, but I think it's better to fix it in broadlink itself. Now that I have a rough idea about what the problem might be, it shouldn't be too difficult to create a separate minimal test case and fix the root cause. (Famous last words.)