Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-1856: Disable ClusterRbacConfig resources #186

Merged
merged 1 commit into from Oct 6, 2020

Conversation

bison
Copy link
Contributor

@bison bison commented Oct 5, 2020

I'm actually not sure what all needs to be done here. This doesn't remove every bit that references the deprecated ClusterRbacConfig resource, but I think it's enough to keep istiod from trying to watch it, which I think is good enough.

@bison
Copy link
Contributor Author

bison commented Oct 5, 2020

Previous PRs: #39 and #75

@dgn
Copy link
Contributor

dgn commented Oct 6, 2020

There are a few integration tests that need to be disabled/removed, other than that this looks good

@bison
Copy link
Contributor Author

bison commented Oct 6, 2020

Yeah, missed those. All fixed.

@mergify mergify bot merged commit 0dd9a23 into maistra:maistra-2.0 Oct 6, 2020
@bison bison deleted the MAISTRA-1856 branch October 6, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants