ignore EWOULDBLOCK and ENOBUFS when sending #41

Merged
merged 1 commit into from Feb 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

schmir commented Feb 8, 2013

this is what the twisted framework also ignores, we trust them here.
the previously used EAGAIN is the same as EWOULDBLOCK on linux.

fixes issue #40

ignore EWOULDBLOCK and ENOBUFS when sending
this is what the twisted framework also ignores, we trust them here.
the previously used EAGAIN is the same as EWOULDBLOCK on linux.

fixes issue #40
Contributor

schmir commented Feb 10, 2013

and WSAWOULDBLOCK is the same as EWOULDBLOCK on windows.

majek added a commit that referenced this pull request Feb 12, 2013

@majek majek merged commit 19fbfa1 into majek:master Feb 12, 2013

Owner

majek commented Feb 12, 2013

okay?

Contributor

schmir commented Feb 12, 2013

no!. errno.EAGAIN is 11 on windows, while errno.EWOULDBLOCK is 10035.
http://msdn.microsoft.com/en-us/library/5814770t.aspx says

EAGAIN
No more processes. An attempt to create a new process failed because there are no more process slots, or there is not enough memory, or the maximum nesting level has been reached.
Owner

majek commented Feb 12, 2013

Now I understand. Okay now?

Contributor

schmir commented Feb 12, 2013

yes, this should work now.

FYI the reason I declared a module level tuple with these constants, was that I wanted to fail early if one of them wasn't defined.

twisted imports WSAEWOULDBLOCK as EWOULDBLOCK. not sure if the former latter hasn't been defined on some prior python version. 2.7 has errno.EWOULDBLOCK.

Owner

majek commented Feb 17, 2013

@schmir Ok. Let's wait for bug reports, I don't think EWOULDBLOCK could be undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment