Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user with a plugin isn't the same as an empty password #115

Merged
merged 1 commit into from Aug 24, 2015

Conversation

grooverdan
Copy link
Contributor

Here if a plugin is set in the user table we don't list that as needed a password set.

jmrenouard added a commit that referenced this pull request Aug 24, 2015
A user with a plugin isn't the same as an empty password
@jmrenouard jmrenouard merged commit 47b702b into major:master Aug 24, 2015
@netsandbox
Copy link
Contributor

@grooverdan @jmrenouard this fix is incomplete, as this wouldn't list users with an empty password and the 'mysql_native_password' or 'mysql_old_password' plugin.

Also, as the plugin is used since MySQL 5.5.7, I think there should be a MySQL Version dependent select, to find the correct users without a password for MySQL version < 5.5.7 and >= 5.5.7 (see http://dev.mysql.com/doc/refman/5.5/en/pluggable-authentication.html).

@grooverdan grooverdan deleted the plugin-ok branch August 24, 2015 08:46
@grooverdan
Copy link
Contributor Author

MySQL 5.7.6+ should probably use https://dev.mysql.com/doc/refman/5.7/en/show-create-user.html

authentication_string is the field added in 5.5.7 when plugins where added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants