fix wrong character offsets spotted by ilmari (RT-116998)

makamaka · Oct 8, 2016 · 322e809 · 322e809
1 parent 9f4c9df
commit 322e809
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/JSON/PP.pm b/lib/JSON/PP.pm
@@ -930,6 +930,7 @@ BEGIN {
             }
         }
 
+        $at-- if defined $ch and $ch ne '';
         decode_error(", or ] expected while parsing array");
     }
 
@@ -996,7 +997,7 @@ BEGIN {
 
         }
 
-        $at--;
+        $at-- if defined $ch and $ch ne '';
         decode_error(", or } expected while parsing object/hash");
     }
 

diff --git a/t/rt_116998_wrong_character_offset.t b/t/rt_116998_wrong_character_offset.t
@@ -0,0 +1,18 @@
+use strict;
+use Test::More;
+BEGIN { plan tests => 4 };
+BEGIN { $ENV{PERL_JSON_BACKEND} = 0; }
+use JSON::PP;
+
+eval { decode_json(qq({"foo":{"bar":42})) };
+like $@ => qr/offset 17/; # 16
+
+eval { decode_json(qq(["foo",{"bar":42})) };
+like $@ => qr/offset 17/;
+
+eval { decode_json(qq(["foo",{"bar":42}"])) };
+like $@ => qr/offset 17/; # 18
+
+eval { decode_json(qq({"foo":{"bar":42}"})) };
+like $@ => qr/offset 17/;
+