Fix is_bool #34
Merged
Fix is_bool #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_bool uses UNIVERSAL::isa, which isn't now recommended.
This notably causes a problem with the string "JSON::PP::Boolean",
which it incorrectly identifies as a boolean value.
Fix by using ->isa("JSON::PP::Boolean") as recommended by perldoc.
|
Thanks! |
rurban
added a commit
to rurban/Cpanel-JSON-XS
that referenced
this pull request
Nov 20, 2017
see the upstream bug in makamaka/JSON-PP#34 where a wrong is_bool check casued the string "JSON::PP::Boolean" to qualify is_bool returning true. Thanks to http://blogs.perl.org/users/leo_lapworth/2017/11/metahack-2.html
|
Shouldn't this be blessed rather than ref? |
charsbar
added a commit
that referenced
this pull request
Nov 20, 2017
|
@jwrightecs, thanks! |
rurban
added a commit
to rurban/Cpanel-JSON-XS
that referenced
this pull request
Jan 6, 2018
see the upstream bug in makamaka/JSON-PP#34 where a wrong is_bool check casued the string "JSON::PP::Boolean" to qualify is_bool returning true. Thanks to http://blogs.perl.org/users/leo_lapworth/2017/11/metahack-2.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_bool uses UNIVERSAL::isa, which isn't now recommended.
This notably causes a problem with the string "JSON::PP::Boolean",
which it incorrectly identifies as a boolean value.
Fix by using ->isa("JSON::PP::Boolean") as recommended by perldoc.