New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN-PR challenge january: fix bug RT#90319 #22

Merged
merged 1 commit into from Oct 15, 2016

Conversation

Projects
None yet
2 participants
@dams
Contributor

dams commented Jan 25, 2015

This PR fixes the RT#90319:encoding then decoding [Math::BigInt->new("0")] were giving ["0"] instead of [0].

This is because at some point a test was being done using || instead of defineness. "0" would be dejsonified into 0, which is correct, that is, defined, but false nevertheless.

I replaced the || by defined(), and added a test. The whole testsuite works and the bug seems fixed. Let me know if you need anything else.

Thanks,
dams

@charsbar

This comment has been minimized.

Show comment
Hide comment
@charsbar

charsbar Apr 21, 2016

Collaborator

@makamaka, please merge this. This is a fix to handle 0 correctly.

Collaborator

charsbar commented Apr 21, 2016

@makamaka, please merge this. This is a fix to handle 0 correctly.

@charsbar charsbar merged commit 7f0fdcd into makamaka:master Oct 15, 2016

@charsbar

This comment has been minimized.

Show comment
Hide comment
@charsbar

charsbar Oct 15, 2016

Collaborator

Thanks!

Collaborator

charsbar commented Oct 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment