Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability: Multiple powers in one controller are not always checked correctly #49

Closed
kratob opened this issue Sep 23, 2019 · 1 comment

Comments

@kratob
Copy link
Member

commented Sep 23, 2019

We have identified a security issue in consul. When a controller has multiple power directives, the :only and :except options of the last directive is applied to all directives. This can lead to unauthenticated access to certain controller actions.

Affected versions: <= 1.0.2
Fixed versions: 1.0.3

Affected code looks like this:

class UsersController < ApplicationController
  power :foo
  power :bar, only: :index

  ...
end

In this example both the powers :foo and :bar are only checked for the #index action. Other actions were left unprotected by powers checks.

Controllers with a single power directive are unaffected. Controllers where neither power uses :only or :except options are unaffected.

This vulnerability has been assigned the CVE identifier CVE-2019-16377.

@kratob

This comment has been minimized.

Copy link
Member Author

commented Sep 23, 2019

Fixed in #48.

@kratob kratob closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.