New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume rspec1 if RSpec::Core is not defined #1

Merged
merged 1 commit into from Feb 15, 2013

Conversation

Projects
None yet
2 participants
@nberger
Contributor

nberger commented Feb 14, 2013

This avoids wrong version detection when RSpec
is defined but rspec 1 is loaded, not rspec 2. For example when
RSpec::Instafail is defined, from rspec-instafail gem

Assume rspec1 if RSpec::Core is not defined
This avoids wrong version detection when RSpec
is defined but rspec 1 is loaded, not rspec 2. For example when
RSpec::Instafail is defined, from rspec-instafail gem

triskweline added a commit that referenced this pull request Feb 15, 2013

Merge pull request #1 from nberger/detect_rspec2_with_rspec_core
Assume rspec1 if RSpec::Core is not defined

@triskweline triskweline merged commit cb5bd33 into makandra:master Feb 15, 2013

@triskweline

This comment has been minimized.

Member

triskweline commented Feb 15, 2013

This is part of the latest gem release. Thanks for the code!

@nberger

This comment has been minimized.

Contributor

nberger commented Feb 15, 2013

Awesome, thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment