Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

add jruby support #29

Merged
merged 3 commits into from

3 participants

@ndrluis

Issue #28

@ndrluis

The error in commit 99ac52c was explained in #28 issue

@makaroni4
Owner

@andreanastacio the build is broken for jruby, you need to specify RUBY_PLATFORM also in https://github.com/andreanastacio/sandi_meter/blob/master/lib/sandi_meter/warning_scanner.rb#L24

Added it plz, squash commits and I will merge it asap :heart:

@bf4

@andreanastacio bump...

@ndrluis ndrluis closed this
@ndrluis ndrluis reopened this
@makaroni4
Owner

Hi @andreanastacio!

How is it going? Is this ping about Open3.capture3 bug fixed in JRuby?

@ndrluis
@makaroni4 makaroni4 merged commit 73abf8c into makaroni4:master

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 14, 2015
  1. @ndrluis

    add jruby support

    ndrluis authored
  2. @ndrluis

    add jruby platform to travis

    ndrluis authored
  3. @ndrluis

    fix indentation

    ndrluis authored
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +4 −0 .travis.yml
  2. +1 −1  lib/sandi_meter/warning_scanner.rb
View
4 .travis.yml
@@ -3,5 +3,9 @@ rvm:
- 1.9.3
- 2.0.0
- 2.1.0
+ - jruby-19mode
+ - jruby-20mode
+ - jruby-head
script:
- bundle exec rake debug
+
View
2  lib/sandi_meter/warning_scanner.rb
@@ -21,7 +21,7 @@ def scan(source)
private
def validate(source)
- Open3.capture3('ruby -wc', stdin_data: source)
+ Open3.capture3("#{RUBY_ENGINE} -wc", stdin_data: source)
end
def check_syntax(status)
Something went wrong with that request. Please try again.