Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: image upload modals, file size limit added to config #2868

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

pablohashescobar
Copy link
Collaborator

@pablohashescobar pablohashescobar commented Nov 24, 2023

This PR fixes some bugs related to the image upload

  1. Separated workspace and user image upload modals.
  2. Removed hardcoded file size limits in the frontend app and use the file_size_limit from the env configs.

@pablohashescobar pablohashescobar changed the base branch from release to develop November 24, 2023 06:41
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am
plane-dev ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 7:46am

@aaryan610 aaryan610 changed the title chore: file size limit refactor: image upload modals, file size limit added to config Nov 24, 2023
@sriramveeraghanta sriramveeraghanta merged commit c7e6118 into develop Nov 24, 2023
10 of 12 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/file_config branch November 24, 2023 07:54
sriramveeraghanta pushed a commit that referenced this pull request Dec 7, 2023
* chore: add file size limit as config in the config api

* refactor: image upload modals

---------

Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants