simple fix for the "backdrop-issue", where you can't add a class to the bootbox's backdrop #560

Open
michapixel opened this Issue Nov 24, 2016 · 5 comments

Projects

None yet

2 participants

@michapixel
michapixel commented Nov 24, 2016 edited

dialog.on("shown.bs.modal", function() { ...

http://getbootstrap.com/javascript/#modals-events

shown.bs.modal

This event is fired when the modal has been made visible to the user (will wait for CSS transitions to complete). If caused by a click, the clicked element is available as the relatedTarget property of the event.

One should add following styles, so the bootbox shows above a normal modal:

.bootbox-backdrop {
	z-index: 120001;
}
.modal.bootbox {
	z-index: 120002;
}
@tiesont
Collaborator
tiesont commented Nov 24, 2016

What issue is this solving?

@tiesont
Collaborator
tiesont commented Nov 24, 2016

I still don't see what this is solving - the line you mention was to add a bootbox class to the backdrop, but it's not used anywhere. @tarlepp - am I missing something here?

@michapixel
@tiesont
Collaborator
tiesont commented Nov 24, 2016 edited

Multiple modals are not supported by Bootstrap, nor by native dialogs. @makeusabrew's intention is that Bootbox mimic the behavior of native dialogs as much as possible.

If you want to demonstrate a use-case that your suggestion solves, create a working example in bootply or jsFiddle. Otherwise, I don't see this change being made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment