New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options grid update and cleanup #423
Conversation
Also did a little cleanup on options grid to space out content a bit. Added CSS rules to initially hide sub-navs on API sidebar.
This should have been deleted from my branch when I first forked it; makeusabrew owns that CNAME.
Sorry, been stacked out with work for the past few weeks. Only comment is the removal of the CNAME file - I don't want to be merging that! :) |
The CNAME bit should just be for my fork. The pages builder keeps trying to
|
You could always add that |
Those IDs are for linking the sidebar nav, so I don't see how classes would On Mon, May 4, 2015 at 4:39 PM, Tarmo Leppänen notifications@github.com
Tieson Trowbridge |
@tiesont I was wrong, was looking this PR with my phone with a bit of hurry... Sorry for that wrong comment. |
@tarlepp No need to apologize, I just wanted to make sure I hadn't missed something obvious. I do need to get better at understanding Git; I thought the pull-request would only include what was committed at the time of the request, but it's obviously including bits like me removing the CNAME file from my fork, which happened afterwards... @makeusabrew If it's easier, I can close/delete this pull request, do a fresh fork, and then commit the changes I intended to be part of the original pull request. |
@tiesont up to you; totally understand why you'd have deleted the CNAME file if GitHub was moaning at you, but as the PR stands merging it would break bootboxjs.com 😢 You can either revert that commit ( |
This reverts commit 87304d3.
@makeusabrew Revert was probably the easiest option... :) |
Added 'value' to options grid.
Also did a little cleanup on options grid to space out content a bit.
Added CSS rules to initially hide sub-navs on API sidebar.