Nick Payne makeusabrew

Organizations

@paynedigital
@makeusabrew
  • @makeusabrew c5dd42f
    add logstash syntax highlighting
@makeusabrew
makeusabrew merged pull request makeusabrew/bootbox#437
@makeusabrew
Add aria-hidden=true to modal template
1 commit with 1 addition and 1 deletion
makeusabrew commented on issue meetfinch/decking#90
@makeusabrew

Hi @vikas027, If that really is the contents of decking.json then yes, it's a simple JSON parse error: JSON always needs to start with an array or …

makeusabrew commented on pull request makeusabrew/bootbox#272
@makeusabrew

Fair point :). I haven't had proper dig back through my own code in a while, sorry. Looking at it again, sanitize(options) is always called and it'…

makeusabrew commented on pull request makeusabrew/bootbox#272
@makeusabrew

RE my main comment about swapping the button order, we could easily just swap the array passed as the second param here...

makeusabrew commented on pull request makeusabrew/bootbox#272
@makeusabrew

Hi @danicomas, Sorry for not getting back to you. I know I've delayed this massively; something about it just doesn't feel quite right. I don't lik…

@makeusabrew

I'm afraid not; the presentation options for dialogs simply follow's Bootstrap's modals - so if they can't be vertically aligned then neither can t…

@makeusabrew

Definitely. The docs still need a lot of work :)

@makeusabrew

Hi Franco, You need to put the return false statement in the initial callback, not the callback invoked by the AJAX request. You'll then have to ma…

@makeusabrew

Not familiar with TypeScript or what the DefinitelyTyped file would need to look like; happy to accept a PR though :)

@makeusabrew
makeusabrew merged pull request makeusabrew/bootbox#428
@makeusabrew
Add Composer support
5 commits with 24 additions and 0 deletions
makeusabrew commented on pull request makeusabrew/bootbox#428
@makeusabrew

Great stuff, happy with this now. Cheers!

@makeusabrew

In versions prior to 3.x it was indeed an array. I can't remember why it changed to an object, but I do remember that there was a very good reason …

@makeusabrew

Yes, it's a false positive since Bootbox will never actually submit the form. The line referenced doesn't look right so I'm guessing you're on an o…

makeusabrew commented on pull request makeusabrew/bootbox#423
@makeusabrew

@tiesont up to you; totally understand why you'd have deleted the CNAME file if GitHub was moaning at you, but as the PR stands merging it would br…