Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projections and GeoFormatTypes #74

Open
rafaqz opened this issue May 23, 2021 · 6 comments
Open

Projections and GeoFormatTypes #74

rafaqz opened this issue May 23, 2021 · 6 comments
Labels
enhancement New feature or request makiecon Issues to address at MakieCon

Comments

@rafaqz
Copy link

rafaqz commented May 23, 2021

JuliaGeo has:

https://github.com/JuliaGeo/GeoFormatTypes.jl

It integrates with ArchGDAL for conversion between projection formats using convert and reprojection of points in any projection format using ArchGDAL.reproject. It handles well known text, proj, epsg, gml and other projection formats without the handling package having to know what they are.

It would be good if we could somehow integrate projections between these packages so that e.g. EPSG projections can be used here.

I'm looking to integrate this with GeoData.jl plotting at some stage. Currently I guess everything could be converted to GeoFormatTypes.ProjString using convert and rewrapped as Projection here? But it might be nice if any projection format just worked.

@visr
Copy link
Collaborator

visr commented May 23, 2021

I think most of the projection code here can be removed once JuliaGeo/Proj.jl#51 lands. Would Proj4.jl not also be the place to add GeoFormatTypes.jl support, like was done in ArchGDAL? Would be nice if only a PROJ dependency would be sufficient for most of these conversions. Although GDAL supports a few more formats still I believe.

@rafaqz
Copy link
Author

rafaqz commented May 23, 2021

Probably is! I just saw all the crs types defined here too. But better to support it at a lower level.

Currently ArchGDAL does belessed type-piracy on convert to allow e.g converting EPSG to WellKnownText. We may need a Plots.jl-like backend system to allow using both.

@asinghvi17
Copy link
Member

Converting to GFT.ProjString should work here, would be a simple enough change. Will look into that after the larger refactor is complete :D

@visr
Copy link
Collaborator

visr commented Feb 14, 2023

It's worth noting that Proj.jl now depends on and accepts GeoFormatTypes since JuliaGeo/Proj.jl#74.

@asinghvi17 asinghvi17 added the makiecon Issues to address at MakieCon label Mar 26, 2023
@asinghvi17
Copy link
Member

#207 begins the path to adding this integration, as I recall.

@asinghvi17
Copy link
Member

It should currently support EPSG, Proj-string, Proj-JSON, and WKT natively. I do still need to add tests though :D

@asinghvi17 asinghvi17 added the enhancement New feature or request label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request makiecon Issues to address at MakieCon
Projects
None yet
Development

No branches or pull requests

3 participants