New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better attachment action features #61

Open
maknz opened this Issue Jun 26, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@maknz
Owner

maknz commented Jun 26, 2016

We've got the base for attachment actions in master (yet unreleased) thanks to @janek2012. I'd like to go further and allow for developers to easily respond to actions when called back by Slack.

I'd also like to simplify the class names (including the existing ones) so things are more fluid. Action rather than AttachmentAction for example.

@maknz maknz added the todo label Jun 26, 2016

@maknz maknz added this to the 2.0 milestone Jun 26, 2016

@maknz maknz self-assigned this Jun 26, 2016

@luckygulli

This comment has been minimized.

Show comment
Hide comment
@luckygulli

luckygulli Jul 6, 2016

I get an error due to this line : 'confirm' => $this->getConfirm()->toArray(),

Call to a member function toArray() on a non-object

So I must at least add 'confirm' => [] to avoid the error (but It show a confirmation Dialog...)

I think we must be able to setConfirm to null (to delete confirmation Dialog) and handle without confirm. :)

I will not have the time to test it as I should do, so I prefer let you do it.

Thank you! :)
PS : Great Job !

luckygulli commented Jul 6, 2016

I get an error due to this line : 'confirm' => $this->getConfirm()->toArray(),

Call to a member function toArray() on a non-object

So I must at least add 'confirm' => [] to avoid the error (but It show a confirmation Dialog...)

I think we must be able to setConfirm to null (to delete confirmation Dialog) and handle without confirm. :)

I will not have the time to test it as I should do, so I prefer let you do it.

Thank you! :)
PS : Great Job !

@youuri

This comment has been minimized.

Show comment
Hide comment
@youuri

youuri May 24, 2017

Hey, still in progress? Need some help maybe?

youuri commented May 24, 2017

Hey, still in progress? Need some help maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment