Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 5.4, throw an exception if JSON encoding fails #48

Merged
merged 2 commits into from Jun 25, 2016
Merged

Conversation

@maknz
Copy link
Owner

maknz commented May 28, 2016

Fixes #27 and replaces #28.

If JSON encoding fails (for example, by bad character encoding), a RuntimeException will be thrown with a descriptive message of the problem.

@maknz maknz force-pushed the json-error branch 6 times, most recently from a963854 to f0ec298 May 28, 2016
@maknz

This comment has been minimized.

Copy link
Owner Author

maknz commented May 28, 2016

Okay, seems 5.4 has some annoying inconsistencies with character encoding, that aren't present in 5.5 and above (as verified by Travis). So I'm inclined to drop 5.4 support. That means we do need to bump the major version to 2.0 when we next release master, but considering we want to introduce support for multiple teams, that'd likely be required anyway.

@maknz maknz mentioned this pull request May 28, 2016
@maknz maknz force-pushed the json-error branch from f0ec298 to e4d379a Jun 25, 2016
@maknz maknz changed the title Throw an exception if JSON encoding fails Drop PHP 5.4, throw an exception if JSON encoding fails Jun 25, 2016
@maknz maknz merged commit d0cd462 into master Jun 25, 2016
3 checks passed
3 checks passed
StyleCI The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@maknz maknz deleted the json-error branch Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.