Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape shell arguments for server and hiddeninput.exe #282

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Escape shell arguments for server and hiddeninput.exe #282

merged 2 commits into from
Oct 22, 2020

Conversation

wgevaert
Copy link
Contributor

fixes #281

Type

Yes/No
Bugfix? Yes
New feature? No
Other? No
Additional information
Yes/No
Has backwards compatibility breaks? No
Has unit and/or integration tests? No

Description

Fixes issue #281, uses php's escapeshellcmd() and escapeshellarg() on commands/args that I think needed them.

@wgevaert
Copy link
Contributor Author

I don't understand the failing check, I did not do anything about that part.

@freost freost merged commit c8ae45f into mako-framework:6.3 Oct 22, 2020
@freost
Copy link
Member

freost commented Oct 22, 2020

Thanks 👍 And sorry for the delay

@freost freost mentioned this pull request Oct 22, 2020
Closed
@wgevaert wgevaert deleted the 6.3 branch October 22, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgevaert @freost