Escape shell arguments for server and hiddeninput.exe#282
Merged
freost merged 2 commits intomako-framework:6.3from Oct 22, 2020
Merged
Escape shell arguments for server and hiddeninput.exe#282freost merged 2 commits intomako-framework:6.3from
freost merged 2 commits intomako-framework:6.3from
Conversation
Contributor
Author
|
I don't understand the failing check, I did not do anything about that part. |
Member
|
Thanks 👍 And sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #281
Type
Additional information
Description
Fixes issue #281, uses php's
escapeshellcmd()andescapeshellarg()on commands/args that I think needed them.