Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape arguments in firetrait::fire #283

merged 4 commits into from Oct 26, 2020


Copy link

@wgevaert wgevaert commented Oct 23, 2020


Bugfix? Yes
New feature? No
Other? No
Additional information
Has backwards compatibility breaks? No
Has unit and/or integration tests? Yes


I missed a popen in my previous PR. When on a system with spaces in the application path, reactor\traits\Firetrait::fire will not throw an error anymore.

I hope these are all things that need to be escaped. Last time I did check all occurences of the commands listed here, which does not mention popen, and now I searched for popen as well, so I hope that's all.

I did edit some tests

@wgevaert wgevaert changed the title 6.3 Escape arguments in firetrait::fire Oct 23, 2020
@freost freost merged commit a00088f into mako-framework:6.3 Oct 26, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants