From 36b2bfb00f9106744b0d9245b50e21de4f15c9d6 Mon Sep 17 00:00:00 2001 From: alessandro Date: Wed, 28 Jan 2015 14:52:22 +0100 Subject: [PATCH] Do not skip commenter for cycle if L2 is not among the singing category for that PR. L2 should still be able to ask for tests. --- process-pull-request | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/process-pull-request b/process-pull-request index 854a9374cffee..93404358f46da 100755 --- a/process-pull-request +++ b/process-pull-request @@ -194,10 +194,8 @@ if __name__ == "__main__": if re.match("merge", first_line): mustMerge = True - # Check L2 signoff - if commenter in CMSSW_L2: - if not [x for x in CMSSW_L2[commenter] if x in signing_categories]: - continue + # Check L2 signoff for users in this PR signing categories + if commenter in CMSSW_L2 and [x for x in CMSSW_L2[commenter] if x in signing_categories]: if re.match("^([+]1|approve[d]?|sign|signed)$", first_line): for sign in CMSSW_L2[commenter]: signatures[sign] = "approved"