border-radius > rounded #57

Open
deadlyhifi opened this Issue Aug 2, 2012 · 4 comments

Projects

None yet

2 participants

@deadlyhifi
Contributor

Again, I can't do a pull request because of my edits but in the SASS and SCSS and possibly some other flavours border-radius has been used where it should be rounded.

Namely any use of border-radius that has a single value in the brackets.

@jina
Contributor
jina commented Aug 2, 2012

I believe you are looking in the Compass versions, in which +rounded is not necessary because +border-radius already exists in Compass. :)

@deadlyhifi
Contributor

I mean within the actual use of the mixins.

e.g. https://github.com/malarkey/320andup/blob/master/scss/_buttons.scss#L33 creates a top right 4px rounded corner where it should be on all corners.

This occurs on a few buttons, and also on the wells within _texture.scss.

@jina
Contributor
jina commented Aug 2, 2012

Hrm, okay I will look into that. When I noticed Andy was calling out a particular corner rather than all corners, I opted for Compass'es mixins instead of Andy's so it'd be less repetitive code. Perhaps I accidentally ported some of that over to the non-Compass files. Will fix once I get a chance to look at it. Thanks!

@deadlyhifi
Contributor

Thats alright, thanks for doing all the porting in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment