Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractCollection is missing methods required to fullfill Collection contract. #9

Closed
trq opened this issue Jul 8, 2016 · 2 comments
Closed

AbstractCollection is missing methods required to fullfill Collection contract. #9

trq opened this issue Jul 8, 2016 · 2 comments

Comments

@trq
Copy link

trq commented Jul 8, 2016

Malarzm\Collections\AbstractCollection appears to be missing the methods add, set, remove and removeElement it requires to implement the interface Doctrine\Common\Collections\Collection.
@malarzm
Copy link
Owner

malarzm commented Jul 8, 2016

Indeed, I must have not included them as all other classes were meant to have their own logic for each of not declared methods. If you need these methods with default behaviour I'm open for accepting a PR :)

@malarzm malarzm mentioned this issue Dec 10, 2016
Merged
@malarzm
Copy link
Owner

malarzm commented Dec 10, 2016

@trq I've added new ArrayCollection with default implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trq @malarzm