From 099d26bf5126a054fbb56eddb52a82e0ff28bf51 Mon Sep 17 00:00:00 2001 From: Ben Marx Date: Fri, 7 Aug 2026 13:08:11 -0700 Subject: [PATCH] e2e/qa: name the gate for instant_allocation_price, not a version The skip path pinned "0.5.10-1 at time of writing" in both the comment and the skip message. Testnet has since moved to 0.5.11-1, so anyone reading either one got a wrong picture of why the subtest skips: it reads as though the pin is behind, when the field is in no release yet. Point at the thing that actually gates it, doublezero-offchain#405, and at where the pin lives. Both stay true as versions move. --- CHANGELOG.md | 3 +++ e2e/qa_multicast_settlement_test.go | 12 ++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bc92a14d..09dc23468 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,9 @@ All notable changes to this project will be documented in this file. ### Changes +- E2E/QA + - `TestQA_MulticastSettlement`'s `validate_instant_allocation_price_matches_chain` no longer names a specific `doublezero_solana_version` in its skip path. Both the comment and the skip message said the pin was `0.5.10-1`; testnet has since moved to `0.5.11-1`, so a reader was told the pin was merely behind when in fact `instant_allocation_price` is in no release yet. They now name what actually gates the field — a doublezero-offchain release carrying doublezero-offchain#405 — and where the pin lives, neither of which goes stale as versions move. Comment and message only, no behaviour change. + ## [v0.34.0](https://github.com/malbeclabs/doublezero/compare/client/v0.33.0...client/v0.34.0) - 2026-08-07 ### Breaking diff --git a/e2e/qa_multicast_settlement_test.go b/e2e/qa_multicast_settlement_test.go index a46224793..4b920ea80 100644 --- a/e2e/qa_multicast_settlement_test.go +++ b/e2e/qa_multicast_settlement_test.go @@ -418,12 +418,12 @@ func TestQA_MulticastSettlement(t *testing.T) { case !quoted.GetReportsInstantAllocationPrice(): // QA hosts install doublezero-solana from a version-pinned apt package // (doublezero_solana_version in malbeclabs/infra - // ansible/inventory/*/group_vars/all.yml, 0.5.10-1 at time of writing), - // so the field only appears once a release carrying it is published and - // the pin bumped. Asserting against an absent field would read 0 and - // fail as "quoted 0, chain 43" — a misleading failure that looks like a - // new bug rather than a rollout gap. - t.Skipf("Skipping: installed doublezero-solana does not report instant_allocation_price (needs a release newer than the pinned 0.5.10-1); chain says %d USDC at last_settled_epoch=%d", + // ansible/inventory//group_vars/all.yml), so the field appears only + // once a doublezero-offchain release carrying it is published and that + // pin is bumped. The column landed in doublezero-offchain#405. Asserting + // against an absent field would read 0 and fail as "quoted 0, chain 43" — + // a misleading failure that looks like a new bug rather than a rollout gap. + t.Skipf("Skipping: installed doublezero-solana does not report instant_allocation_price (needs a release carrying doublezero-offchain#405); chain says %d USDC at last_settled_epoch=%d", onchain.InstantAllocationDollars, onchain.LastSettledEpoch) case quoted.InstantAllocationPrice == nil: // Reported, but null: the CLI could not find the settled-epoch ring