Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misc issues with `dag_paths()` and `geom_dag_edges_fan()` #31

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@malcolmbarrett
Copy link
Owner

malcolmbarrett commented Feb 12, 2020

Closes #26

This PR fixes bugs that prevented dag_paths() from working well with dplyr 1.0.0, fixes several issues with plotting in geom_dag_edges_fan(), generally cleans up ggdag_paths_fan(), and adds tests for all of the above

@malcolmbarrett malcolmbarrett merged commit 9da7901 into master Feb 12, 2020
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 92.85% of diff hit (target 63.09%)
Details
codecov/project 70.17% (+7.08%) compared to 1f3cf10
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@malcolmbarrett malcolmbarrett deleted the fix_fan_bug branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.