Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove `use_defaults()` from ggproto methods #33

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

@malcolmbarrett
Copy link
Owner

malcolmbarrett commented Feb 13, 2020

Closes #23

This PR removes the use of use_defaults() in the ggproto method. This was a hack in the first place meant to skirt around a long-fixed bug in ggraph, so good riddance. Now, defaults for *_cap aesthetics are set in default_aes, where they should be.

@malcolmbarrett malcolmbarrett merged commit 88425a1 into master Feb 13, 2020
11 checks passed
11 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch Coverage not affected when comparing 10650b8...8324fc5
Details
codecov/project 70.16% remains the same compared to 10650b8
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@malcolmbarrett malcolmbarrett deleted the ggplot_updates branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.