UserProfile.language should be linked to Language model #15

Closed
malcolmt opened this Issue Aug 19, 2010 · 2 comments

Projects

None yet

1 participant

@malcolmt
Owner

We should migrate UserProfile.language to be a ForeignKey to the Language model, for consistency. This involves changing all the code that refers to UserProfile.

For efficiency, it probably makes sense to make Language.code a primary key, however, this is fiddly with migrations, as the backwards migration will be difficult to write.

@malcolmt
Owner

I've started working on this one (in a local branch for now). Made the field migrations, but still need to port across all the code that uses the language attribute. Noting this here so that Matt doesn't start accidentally working on it.

@malcolmt
Owner

Change all code to use Profile.language_pref. Closed by 01fee78.

Anything that used to be indexed from a language code is now indexed
from a Language.id value (sometimes written as
Profile.language_pref_id).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment