New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Promise+Zip.swift #56

Merged
merged 31 commits into from Oct 27, 2017

Conversation

Projects
None yet
5 participants
@bryanbartow

bryanbartow commented Oct 10, 2017

Fixes bug in four promise zip which would cause crash as d was never passed to all

hy9be and others added some commits Aug 21, 2017

Fix #42
Replace ``DispatchTime(uptimeNanoseconds: UInt64.mx)`` with ``DispatchTime.distantFuture`` to fix the crash
Merge pull request #43 from hy9be/fix/await-crash
Await does not work on iOS 11
Fix #46 - Cancel timeout task on success
Cancel timeout task on success, avoid delayed multiple call
Fix #46
Fix #46 : Promise with chained timeout operator is released correctly when resolves before timeout interval is fired.
Fix #45
Fix #45 : Added support for cancellable promise in async operator, including test.
Merge branch 'feature/swift-4' into develop
# Conflicts:
#	Configs/Hydra.plist
#	Hydra.xcodeproj/project.xcworkspace/xcuserdata/dan.xcuserdatad/UserInterfaceState.xcuserstate
#	HydraAsync.podspec
#	README.md
Merge branch 'release/1.1.0'
# Conflicts:
#	CHANGELOG.md
#	README.md
Update Promise+Zip.swift
Fixes bug in four promise zip which would cause crash as d was never passed to all
@bryanbartow

This comment has been minimized.

Show comment
Hide comment
@bryanbartow

bryanbartow Oct 10, 2017

This actually needs to be submitted against the Swift 3 branch. I'll close and resubmit.

bryanbartow commented Oct 10, 2017

This actually needs to be submitted against the Swift 3 branch. I'll close and resubmit.

@bryanbartow

This comment has been minimized.

Show comment
Hide comment
@bryanbartow

bryanbartow Oct 10, 2017

It turns out there is no Swift 3 branch. Reopening...

bryanbartow commented Oct 10, 2017

It turns out there is no Swift 3 branch. Reopening...

@bryanbartow bryanbartow reopened this Oct 10, 2017

@bryanbartow

This comment has been minimized.

Show comment
Hide comment
@bryanbartow

bryanbartow Oct 10, 2017

It would be helpful to create a Swift 3 release incorporating this fix.

bryanbartow commented Oct 10, 2017

It would be helpful to create a Swift 3 release incorporating this fix.

malcommac added a commit that referenced this pull request Oct 27, 2017

@malcommac malcommac changed the base branch from master to swift-3 Oct 27, 2017

@malcommac malcommac added this to the 1.0.2 milestone Oct 27, 2017

@malcommac malcommac added the bug label Oct 27, 2017

@malcommac malcommac merged commit 46c90d5 into malcommac:swift-3 Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment