This repository was archived by the owner on Mar 5, 2026. It is now read-only.
YARA rule cleanup#3
Merged
Merged
Conversation
Contributor
wesinator
commented
Oct 30, 2018
wesinator
commented
- Convert PEiD signatures file encoding to UTF-8
- Change yara file permissions to 0644
- Space out rules in userdb_panda.yar
- Disable bad Armadillo v1.71 PEiD rules (Remove false positive PEiD Armadillo packer signatures pescan#1)
Change to standard 0644
This signature is a false positive
Member
|
Hello, sorry for the delay, but why is it important that the descriptions be proper utf-8? It seems to not have an affect on the actual detection? I apologize if I am missing something. |
Contributor
Author
|
Doesn't affect detection, just makes the file easier to edit in certain editors that don't support the encoding (gedit). It also shows Chinese chars correctly, 5e43146#diff-47f2da197695b69ba377b17309eb8435R10794 |
Member
|
I can dig it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.