Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

[nemo-keyboard] Glacier-UI graphics #4

Closed
wants to merge 2 commits into from
Closed

Conversation

locusf
Copy link
Contributor

@locusf locusf commented Sep 18, 2013

This is a graphics update to nemo-keyboard with Glacier UI specification conforming keyboard (https://github.com/qwazix/glacier-controls-spec). Updates also include popper, key graphics and keyboard background graphics.

@mikhas
Copy link
Member

mikhas commented Sep 23, 2013

Thanks for the contribution! Is the Glacier UI becoming default for Nemomobile?

@locusf
Copy link
Contributor Author

locusf commented Sep 23, 2013

I hope so :)

@@ -53,6 +58,14 @@ KeyBase {
anchors.bottomMargin: bottomPadding
}

onPressedChanged: {
if (pressed) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the source is both set declaratively on bgimage and imperatively on this handler. How about just using BordegImage { [...] source: parent.pressed ? "..." : "..."?

@locusf
Copy link
Contributor Author

locusf commented Oct 16, 2013

Addressed the issues, what about the landscape keyboard, do you guys want that too?

@mikhas
Copy link
Member

mikhas commented Oct 21, 2013

I guess we want the landscape keyboard, yeah …but could do in a separate pull request. Sorry for me being so unresponsive with this PR :-(

@locusf
Copy link
Contributor Author

locusf commented Oct 21, 2013

No problem :) , is this ok now though?

@mikhas
Copy link
Member

mikhas commented Oct 30, 2013

OK, merged it now but couldn't notice the fancy new graphics. Is there anything special needed to test with Nemo Keyboard?

@mikhas mikhas closed this Oct 30, 2013
@locusf
Copy link
Contributor Author

locusf commented Oct 30, 2013

You didn't merge a thing or is it really my commits that don't come visible?

@mikhas
Copy link
Member

mikhas commented Oct 31, 2013

Hm, no idea … shouldn't be those two commits?
f65ff8e
c1ce078

@locusf
Copy link
Contributor Author

locusf commented Oct 31, 2013

Yes those are correct.

@mikhas
Copy link
Member

mikhas commented Oct 31, 2013

OK, those two commits are the last two in master, unless I did something stupid.

@locusf
Copy link
Contributor Author

locusf commented Nov 1, 2013

maliit-plugins is not yet visible with this change (nemomobile-packages), PR has been issued.

@locusf
Copy link
Contributor Author

locusf commented Nov 2, 2013

Please see: nemomobile-packages/maliit-plugins#1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants