Skip to content

Malini Das malini

malini commented on pull request aosabook/500lines#44
Malini Das

Thanks for the thorough review! I'll be away for the week for meetings and taking the weekend to recover from jetlag, so I'll take a look next week.

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

Looks good to me!

Malini Das
  • Malini Das 7fdfd12
    update according to reviewer's comment
Malini Das
  • Malini Das cbba368
    update according to reviewer's comment
malini commented on pull request aosabook/500lines#44
Malini Das

I've updated the code base according the reviewer's comments, and I've also added a feature (test runner management) and some refactoring (shell sc…

Malini Das
malini merged pull request malini/500lines#2
Malini Das
Runner management
8 commits with 201 additions and 170 deletions
malini commented on pull request malini/500lines#2
Malini Das

Also refactors the shell scripts to be less repetitive and to share code.

malini opened pull request malini/500lines#2
Malini Das
Runner management
8 commits with 201 additions and 170 deletions
Malini Das
  • Malini Das bb3c79d
    remove dispatched jobs from pending
Malini Das
  • Malini Das 9cbf2ce
    update documentation, and remove unused code
malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

where are we testing these removed checks?

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

The files have been removed without being replaced in this patch

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

nitpick: extra new line

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

In case this happens, we should log to the results file so we can know why we see so many failures

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

can you match the exact app name?

malini commented on pull request mozilla-b2g/fxos-certsuite#134
Malini Das

This line can be removed, or it can be moved to line 173

Malini Das
Malini Das
Malini Das
  • Malini Das ed5df64
    update based on PR comments
Malini Das
malini commented on pull request mozilla-b2g/fxos-appgen#9
Malini Das

tested locally, works well. After you change the version, feel free to merge and upload the package

malini commented on pull request mozilla-b2g/fxos-appgen#9
Malini Das

looks good, can you bump this to 0.5 since it's a bigger change?

malini closed pull request mozilla-b2g/fxos-appgen#8
Malini Das
Expose functionality to check if app is installed in new function is_installed
malini commented on pull request mozilla-b2g/fxos-appgen#8
Malini Das

pushed an updated patch and released a new package

Malini Das
  • Malini Das fe9729b
    add is_installed, and change adb_path default to 'adb'
malini commented on pull request mozilla-b2g/fxos-appgen#8
Malini Das

you need to check if adb_path is None and use 'adb' if not due to https://github.com/mozilla-b2g/fxos-appgen/blob/master/fxos_appgen/generator.py#L75

malini commented on pull request mozilla-b2g/fxos-appgen#8
Malini Das

there's a typo here, it should be 'webapps'

Malini Das
Only install marionette if marionette is not on the device
malini commented on pull request mozilla-b2g/fxos-certsuite#106
Malini Das

lgtm!

Something went wrong with that request. Please try again.