Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds parameter to RoadGeometryConfiguration to set xodr parsing strictness #59

Merged
merged 3 commits into from May 19, 2021
Merged

Adds parameter to RoadGeometryConfiguration to set xodr parsing strictness #59

merged 3 commits into from May 19, 2021

Conversation

francocipollone
Copy link
Collaborator

Part of #55

@francocipollone francocipollone mentioned this pull request May 19, 2021
Open
agalbachicar
agalbachicar approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nit: if you could change to permissive it'd be better.

@francocipollone francocipollone force-pushed the francocipollone/#55_add_parameter_to_road_geometry_config branch from cd23dcc to 324eee1 Compare May 19, 2021 15:51
agalbachicar
agalbachicar approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 3925029 into main May 19, 2021
@francocipollone francocipollone deleted the francocipollone/#55_add_parameter_to_road_geometry_config branch May 19, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francocipollone @agalbachicar